The overall progress could be inaccurate since po files with 100% translation progress are excluded #7

New Issue

mattwang44 · 2023-08-29T10:22:48Z

mattwang44 commented

2023-08-29 10:22:48 +00:00

Hi team,

Thanks for implementing and maintaining this wonderful tool! I use it frequently in our project to keep track of the translation progress. Much appreciated!

One tiny awkward thing I spotted today is that, after I finished the translation of one po file in my project, the overall progress (displayed in the last line of the CLI output) somewhat dropped. I believe the root cause is the po files with 100% translation progress being excluded from being displayed in the output and deriving for the overall progress (source). I wonder if this behavior is expected. If not, I'm willing to send a PR for this, but would like to have a discussion about how to modify it correctly first (e.g. consider 100% po files when calculating the overall progress, but still hide them from the output?).

Thanks again!

Hi team, Thanks for implementing and maintaining this wonderful tool! I use it frequently in our project to keep track of the translation progress. Much appreciated! One tiny awkward thing I spotted today is that, after I finished the translation of one po file in my project, the overall progress (displayed in the last line of the CLI output) somewhat dropped. I believe the root cause is the po files with 100% translation progress being excluded from being displayed in the output and deriving for the overall progress ([source](https://git.afpy.org/AFPy/potodo/src/commit/27f36b6a1bfda9dc5b5388776a1d587b5505799c/potodo/potodo.py#L134-L138)). I wonder if this behavior is expected. If not, I'm willing to send a PR for this, but would like to have a discussion about how to modify it correctly first (e.g. consider 100% po files when calculating the overall progress, but still hide them from the output?). Thanks again!

👍 1

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AFPy/potodo#7