I have hard times reviewing PR of more than 200 lines. #231

mdk · 2023-11-25T14:42:49Z

mdk commented

2023-11-25 14:42:49 +00:00

Smaller PR are:

Faster to review: reviewers may not have many free hours straight.
Easier to merge: if a translator does a lot of work, better have
part of it merged quickly (by merging good PRs) instead of blocking
the whole work due to a small detail.

Smaller PR are: - Faster to review: reviewers may not have many free hours straight. - Easier to merge: if a translator does a lot of work, better have - part of it merged quickly (by merging good PRs) instead of blocking - the whole work due to a small detail.

mdk added 1 commit 2023-11-25 14:42:49 +00:00

b846b2d587

I have hard times reviewing PR of more than 200 lines.

Smaller PR are:

- Faster to review: reviewers may not have many free hours straight.
- Easier to merge: if a translator does a lot of work, better have
- part of it merged quickly (by merging good PRs) instead of blocking
- the whole work due to a small detail.

ChristopheNan approved these changes 2023-11-25 15:56:53 +00:00

ChristopheNan commented

2023-11-25 15:57:34 +00:00

La directive n'est valable que pour les prochaines PR !

😆 1

ChristopheNan merged commit 20e75e0336 into 3.11

2023-11-25 15:57:43 +00:00

ChristopheNan referenced this issue from a commit

2023-11-25 15:57:44 +00:00

I have hard times reviewing PR of more than 200 lines. (#231)

Sign in to join this conversation.

No reviewers