AFPy/potodo
AFPy/potodo
11
3
Fork 7
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity

Fix CLI for --pot flag #16

Merged
mdk merged 1 commit from maciek/potodo:fix-pot-cli into main 2025-10-16 16:06:25 +02:00
Conversation 3 Commits 1 Files changed 1 +1 -3
maciek commented 2025-01-18 02:10:10 +01:00
Contributor
Copy link

Implementation in #11 is crashing on using a pot flag in the CLI. We've been removing temporary directory before printing the statistics. And printing was crashing.

Only the code interface was being tested before. I'm sorry for missing the CLI part.

I also needed to remove path.resolve() in build_ignore_matcher(). With the resolving the CLI was crashing when building while using temporary paths.

Implementation in #11 is crashing on using a pot flag in the CLI. We've been removing temporary directory before printing the statistics. And printing was crashing. Only the code interface was being tested before. I'm sorry for missing the CLI part. I also needed to remove path.resolve() in build_ignore_matcher(). With the resolving the CLI was crashing when building while using temporary paths.
It doesn't play well with temporary directory, when it includes symlink in it. (Case for MacOS.)
maciek commented 2025-01-18 18:33:12 +01:00
Author
Contributor
Copy link

The CI issue could be https://codeberg.org/Codeberg-CI/feedback/issues/201. They say that there's a fix button in settings?

The CI issue could be https://codeberg.org/Codeberg-CI/feedback/issues/201. They say that there's a fix button in settings?
mattwang44 approved these changes 2025-02-04 18:32:18 +01:00
mattwang44 left a comment
Copy link

LGTM
(I can't see the CI status from my side, it might be restricted to authors and maintainers?)

LGTM (I can't see the CI status from my side, it might be restricted to authors and maintainers?)
maciek commented 2025-02-04 23:22:55 +01:00
Author
Contributor
Copy link

CI has some troubles recently. https://woodpecker.afpy.org/repos/23 It does not report on the status of repository.

pipeline definition not found in AFPy/potodo

It looks similar to an issue described here: https://codeberg.org/Codeberg-CI/feedback/issues/201.

CI has some troubles recently. https://woodpecker.afpy.org/repos/23 It does not report on the status of repository. > pipeline definition not found in AFPy/potodo It looks similar to an issue described here: https://codeberg.org/Codeberg-CI/feedback/issues/201.
👍 1
mdk merged commit ae97eb77b6 into main 2025-10-10 14:33:43 +02:00
mdk deleted branch fix-pot-cli 2025-10-10 14:33:44 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mattwang44
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AFPy/potodo!16
No description provided.