AFPy/potodo
AFPy/potodo
11
3
Fork 7
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity

Accept position arguments, I'm tired of forgetting -p #27

Merged
mdk merged 2 commits from mdk/potodo:mdk-p into main 2025-10-24 17:06:03 +02:00
Conversation 1 Commits 2 Files changed 4 +50 -31
mdk commented 2025-10-23 21:19:08 +02:00
Owner
Copy link

Hum oops I have a totally unrelated change, simplifying an if not any.

Hum oops I have a totally unrelated change, simplifying an `if not any`.
Accept position arguments, I'm tired of forgetting -p
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
2ffb148059
maciek approved these changes 2025-10-23 21:54:00 +02:00
maciek left a comment
Copy link

Looks good to me, left some nitty suggestions

It's very nice simplification of the API 💯

Looks good to me, left some nitty suggestions It's very nice simplification of the API 💯
potodo/arguments_handling.py Outdated
@ -22,2 +22,4 @@
def handle_dash_p_compat(args: argparse.Namespace) -> None:
"""Could be remonved in like 2028.
maciek commented 2025-10-23 21:45:20 +02:00
Contributor
Copy link

nit: remonved -> removed

nit: remonved -> removed
mdk marked this conversation as resolved
potodo/arguments_handling.py
@ -24,0 +34,4 @@
"🍰 hint: using -p to invoke potodo became optional in potodo 0.3.",
file=sys.stderr,
)
print(" (and may be removed in the future)", file=sys.stderr)
maciek commented 2025-10-23 21:47:15 +02:00
Contributor
Copy link

nit suggestion: make those a one print with \n at the end of the first line

nit suggestion: make those a one print with `\n` at the end of the first line
mdk marked this conversation as resolved
potodo/arguments_handling.py
@ -38,0 +56,4 @@
parser.add_argument(
"paths",
help="Examine files in the given path",
maciek commented 2025-10-23 21:47:49 +02:00
Contributor
Copy link

Examine files in the given path -> Examine files in given path(s)

Examine files in the given path -> Examine files in given path(s)
mdk marked this conversation as resolved
potodo/arguments_handling.py Outdated
@ -239,3 +264,3 @@
# If no path is specified, use current directory
if not args.paths:
if not args.paths and not args.old_paths:
maciek commented 2025-10-23 21:52:49 +02:00
Contributor
Copy link

superfluous: we call handle_dash_p_compat before check_args

superfluous: we call `handle_dash_p_compat` before `check_args`
mdk commented 2025-10-24 09:14:57 +02:00
Author
Owner
Copy link

Adding a del args.old_paths in handle_dash_p_compat.

Adding a `del args.old_paths` in `handle_dash_p_compat`.
mdk marked this conversation as resolved
Review by maciek
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
1480737776
mdk merged commit 9dc0a0025d into main 2025-10-24 17:06:03 +02:00
mdk deleted branch mdk-p 2025-10-24 17:06:04 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
maciek
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AFPy/potodo!27
No description provided.