AFPy/powrap
10
0
Fork 2
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Improve parse_args #2

Merged
mdk merged 1 commit from rffontenelle/powrap:rffontenelle-improve-parse_args into main 2023-07-18 14:13:19 +02:00
Conversation 2 Commits 1 Files changed 1 +4 -3
rffontenelle commented 2023-06-03 17:44:31 +02:00
Contributor
Copy link

This solves two minor issues of the powrap --help output:

  • First one is that argparse shows short and then long form of --help option, while powrap's arguments show long and then short, causing it to look like:
options:
  -h, --help      show this help message and exit
  --modified, -m  Use git to find modified files ...
  -C GIT_ROOT     To use with --modified to tell ...
  --quiet, -q     Do not show progress bar ...
  ...
  • The other thing is that the exit code is set in multi-line string, but not actually printed as multi-line string. While it looks compacted and OK in the printed help message, I assume that's not the intended so I set RawTextHelpFormatter to make sure the formatting is honored.
exit code: 0:nothing to do 1:would rewrap 127:error running msgcat
This solves two minor issues of the `powrap --help` output: - First one is that argparse shows short and then long form of --help option, while powrap's arguments show long and then short, causing it to look like: ``` options: -h, --help show this help message and exit --modified, -m Use git to find modified files ... -C GIT_ROOT To use with --modified to tell ... --quiet, -q Do not show progress bar ... ... ``` - The other thing is that the exit code is set in multi-line string, but not actually printed as multi-line string. While it looks compacted and OK in the printed help message, I assume that's not the intended so I set RawTextHelpFormatter to make sure the formatting is honored. ``` exit code: 0:nothing to do 1:would rewrap 127:error running msgcat ```
Improve parse_args
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
a0b4a1eeb0 
Signed-off-by: rffontenelle <rffontenelle@gmail.com>
mdk approved these changes 2023-07-18 14:11:23 +02:00
mdk commented 2023-07-18 14:12:58 +02:00
Owner
Copy link

Thanks a lot !!!

Thanks a lot !!!
mdk merged commit a34a9fed11 into main 2023-07-18 14:13:19 +02:00
mdk deleted branch rffontenelle-improve-parse_args 2023-07-18 14:13:19 +02:00
mdk referenced this pull request from a commit 2023-07-18 14:13:19 +02:00
Improve parse_args (#2)
Sign in to join this conversation.
Reviewers
No reviewers
mdk
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AFPy/powrap!2
No description provided.