AFPy/python-docs-fr
AFPy
/
python-docs-fr
5
6
Fork 44
Code Issues 23 Pull Requests 13 Projects Releases Wiki Activity

Upgrade woodpecker config #235

Merged
mdk merged 1 commits from mdk/python-docs-fr:mdk-woodpecker into 3.11 2023-12-01 21:54:36 +00:00
Conversation 4 Commits 1 Files Changed 2 +36 -4
mdk commented 2023-11-30 15:00:16 +00:00
Owner
Copy Link

Also I don't remember why there's those git things here, so let's try
without…

Also I don't remember why there's those git things here, so let's try without…
mdk commented 2023-11-30 15:03:11 +00:00
Author
Owner
Copy Link

Ahhh les petits trucs git c'était pour SRCS = $(shell git diff --name-only --diff-filter=d $(BRANCH) | grep '.po$$').

Et là on dirait que ça passe sans, est-ce que woodpecker à changé sa manière de fetch?

Ahhh les petits trucs git c'était pour `SRCS = $(shell git diff --name-only --diff-filter=d $(BRANCH) | grep '.po$$')`. Et là on dirait que ça passe sans, est-ce que woodpecker à changé sa manière de `fetch`?
mdk commented 2023-11-30 15:11:46 +00:00
Author
Owner
Copy Link

Oh wow, woodpecker does strange things:

git branch -va
* 3.11 f996afa I don't get it.

it tells git that my PR is the 3.11 branch, funny...?

Oh wow, woodpecker does strange things: ``` git branch -va * 3.11 f996afa I don't get it. ``` it tells git that my PR is the 3.11 branch, funny...?
mdk changed title from Woodpecker: renamed pipeline to steps. to [WIP] Woodpecker: renamed pipeline to steps. 2023-11-30 16:59:52 +00:00
mdk force-pushed mdk-woodpecker from 8f54220823 to a488c776fc 2023-11-30 21:39:09 +00:00 Compare
mdk changed title from [WIP] Woodpecker: renamed pipeline to steps. to Upgrade woodpecker config 2023-11-30 21:39:26 +00:00
mdk commented 2023-11-30 21:40:56 +00:00
Author
Owner
Copy Link

Donc oui, amusant, par défaut la branche qui est crée pour le checkout c'est "CI_COMMIT_BRANCH" qui vaut la branche cible dans le cas d'une PR, cf. https://woodpecker-ci.org/plugins/Git%20Clone et https://woodpecker-ci.org/docs/usage/environment#built-in-environment-variables.

Donc oui, amusant, par défaut la branche qui est crée pour le checkout c'est "CI_COMMIT_BRANCH" qui vaut la branche cible dans le cas d'une PR, cf. https://woodpecker-ci.org/plugins/Git%20Clone et https://woodpecker-ci.org/docs/usage/environment#built-in-environment-variables.
mdk commented 2023-12-01 12:16:45 +00:00
Author
Owner
Copy Link

C'est bon pour moi, qqun se sent de review ? :)

C'est bon pour moi, qqun se sent de review ? :)
ChristopheNan reviewed 2023-12-01 12:34:50 +00:00
.woodpecker.yml Outdated
@ -4,0 +22,4 @@
fetch target branch:
image: python
commands:
- BRANCH="$(grep ^BRANCH Makefile | awk '{print $3}')"
ChristopheNan commented 2023-12-01 12:34:50 +00:00
Collaborator
Copy Link

Ceci suppose que nous mettions bien une espace avant et après le :=
Supposition suffisamment fiable ? utiliser ${CI_COMMIT_SOURCE_BRANCH} ?

Ceci suppose que nous mettions bien une espace avant et après le *:=* Supposition suffisamment fiable ? utiliser ${CI_COMMIT_SOURCE_BRANCH} ?
mdk commented 2023-12-01 14:44:13 +00:00
Author
Owner
Copy Link

0021762563 ?

https://git.afpy.org/AFPy/python-docs-fr/commit/002176256383a870d3d93bed300fea3a4ccf8569 ?
👍 1
mdk marked this conversation as resolved
ChristopheNan reviewed 2023-12-01 15:52:05 +00:00
.woodpecker.yml Outdated
@ -4,0 +24,4 @@
commands:
- BRANCH="$(make print-BRANCH)"
- git fetch origin --no-tags +refs/heads/$BRANCH
- 'git branch $BRANCH origin/$BRANCH ||:'
ChristopheNan commented 2023-12-01 15:52:05 +00:00
Collaborator
Copy Link

Le ||: est toujours nécessaire, sachant que l'on déclenche seulement en cas de PR ?
Il répond toujours vrai, donc masque les erreurs...

Le *||:* est toujours nécessaire, sachant que l'on déclenche seulement en cas de PR ? Il répond toujours vrai, donc masque les erreurs...
mdk commented 2023-12-01 21:51:22 +00:00
Author
Owner
Copy Link

Je l'enlève, on verra s'il gêne, dans ce cas ça méritera un commentaire.

Je l'enlève, on verra s'il gêne, dans ce cas ça méritera un commentaire.
mdk marked this conversation as resolved
ChristopheNan approved these changes 2023-12-01 16:43:16 +00:00
mdk force-pushed mdk-woodpecker from 0021762563 to af33329364 2023-12-01 21:51:43 +00:00 Compare
mdk merged commit af33329364 into 3.11 2023-12-01 21:54:36 +00:00
mdk deleted branch mdk-woodpecker 2023-12-01 21:54:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ChristopheNan
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

Pour les issues à propos du repo, de l'organisation, ...

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
meta
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AFPy/python-docs-fr#235
No description provided.
Delete Branch "mdk/python-docs-fr:mdk-woodpecker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?