Barbagus
  • Joined on 2022-12-08
Barbagus pushed to barbadev at fcode/delarte 2022-12-20 09:13:43 +00:00
Barbagus created branch barbadev in fcode/delarte 2022-12-20 09:13:43 +00:00
Barbagus deleted branch WIP-CLI-argument-#1 from fcode/delarte 2022-12-20 09:12:47 +00:00
Barbagus deleted branch 11-custom-renditions from fcode/delarte 2022-12-20 09:12:44 +00:00
Barbagus pushed to stable at fcode/delarte 2022-12-20 09:11:51 +00:00
458d4cbb6d Add sample files
Barbagus commented on issue fcode/delarte#12 2022-12-20 09:00:06 +00:00
Terminology and harmful language consideration

I share the idea of not exposing HLS specific terminology (rendition, variants) to the user. But I have to say that the term version is making me nervous as it carries already a lot of meaning…

Barbagus closed pull request fcode/delarte#17 2022-12-20 08:54:47 +00:00
WPI: CLI-argument-#1
Barbagus closed pull request fcode/delarte#16 2022-12-20 08:54:35 +00:00
WIP: Custom renditions #11
Barbagus commented on issue fcode/delarte#1 2022-12-20 08:53:53 +00:00
CLI argument/options and default behaviours

Thanks @remace07 for the initial push with about this issue !

I suggest we keep this issue open to discusse future options/default values strategy.

Barbagus pushed to stable at fcode/delarte 2022-12-20 08:49:33 +00:00
1eb4d8557d Spell check
Barbagus commented on pull request fcode/delarte#17 2022-12-18 20:12:31 +00:00
WPI: CLI-argument-#1

Okay why not :)

Barbagus commented on pull request fcode/delarte#17 2022-12-16 07:29:35 +00:00
WPI: CLI-argument-#1

Alright, I discussed the named vs. positional in #1

For the rest it looks fine to me, last time I checked I picked up that

  • there was still some french docstrings
  • you rewrote the usage…
Barbagus commented on issue fcode/delarte#1 2022-12-16 07:20:11 +00:00
CLI argument/options and default behaviours

I am not saying that flags must only be used for special cases (help message, version number, ...) or to overwrite default values or behaviours (human redable vs machine parsebale outputs,…

Barbagus commented on issue fcode/delarte#1 2022-12-16 07:14:38 +00:00
CLI argument/options and default behaviours

My response to #17

a user that provides a link, and a resolution but no language code would be badly interpreted by argparse: positionnal arguments HAVE TO be given in the very order of the…

Barbagus commented on issue fcode/delarte#1 2022-12-16 06:56:38 +00:00
CLI argument/options and default behaviours

Taking the conversation from #17 over here as it is more a talk about user interface and functionalities than one about implementation.

To sum up, @remace07 proposes this interface:

delart…
Barbagus commented on pull request fcode/delarte#17 2022-12-15 11:02:32 +00:00
WPI: CLI-argument-#1

As for now, we always need the (url, version, resolution) arguments and we process them in that very order (and only the last one might ever have a default value one day, see below). So I don't…

Barbagus commented on issue fcode/delarte#11 2022-12-15 10:45:04 +00:00
Custom renditions

Okay, after few hours playing with the idea, this urns out to be a very deep rabbit hole.

Even if for a specific case one could manage to mix and match, there is just too many assumptions/guess…

Barbagus commented on pull request fcode/delarte#17 2022-12-14 14:32:24 +00:00
WPI: CLI-argument-#1

for the commit "fix HLS", it comes from stable from which I did the branch. I think that's why it's still here. to be fair, i'm not a git wizard at all, I don't know why it appears if it's not…

Barbagus pushed to stable at fcode/delarte 2022-12-14 12:56:37 +00:00
14b9c1bb11 Adds the tests directory
Barbagus commented on pull request fcode/delarte#17 2022-12-14 12:54:03 +00:00
WPI: CLI-argument-#1

Also I will push the creation of tests/__init__.py and the pytest configuration in the pyproject.toml before we push this.

Just so testing it has it's own moment of glory in…