I share the idea of not exposing HLS specific terminology (rendition, variants) to the user. But I have to say that the term version
is making me nervous as it carries already a lot of meaning…
Thanks @remace07 for the initial push with about this issue !
I suggest we keep this issue open to discusse future options/default values strategy.
Alright, I discussed the named vs. positional in #1
For the rest it looks fine to me, last time I checked I picked up that
- there was still some french docstrings
- you rewrote the usage…
I am not saying that flags must only be used for special cases (help message, version number, ...) or to overwrite default values or behaviours (human redable vs machine parsebale outputs,…
My response to #17
a user that provides a link, and a resolution but no language code would be badly interpreted by argparse: positionnal arguments HAVE TO be given in the very order of the…
Taking the conversation from #17 over here as it is more a talk about user interface and functionalities than one about implementation.
To sum up, @remace07 proposes this interface:
delart…
As for now, we always need the (url, version, resolution) arguments and we process them in that very order (and only the last one might ever have a default value one day, see below). So I don't…
Okay, after few hours playing with the idea, this urns out to be a very deep rabbit hole.
Even if for a specific case one could manage to mix and match, there is just too many assumptions/guess…
for the commit "fix HLS", it comes from stable from which I did the branch. I think that's why it's still here. to be fair, i'm not a git wizard at all, I don't know why it appears if it's not…
Also I will push the creation of
tests/__init__.py
and the pytest configuration in thepyproject.toml
before we push this.Just so testing it has it's own moment of glory in…