fcode/delarte
3
2
Fork 1
Code Issues 1 Pull requests 1 Projects 1 Releases Activity

Choix du répertoire de téléchargement temporaire #2

New issue
Closed
opened 2022-12-07 02:02:18 +01:00 by remace07 · 5 comments
remace07 commented 2022-12-07 02:02:18 +01:00
Collaborator
Copy link

en: for instance, the content is downloaded in the project directory by default. my suggestion is to allow user to provide a destination directory in the CLI command.

this would make a user able to use a command alias from any directory and downloading the data to a parametered directory, or by default in the current working directory.

fr: pour l'instant, le contenu est téléchargé par défaut dans le répertoire du projet. ma suggestion serait de rajouter un paramètre dans la commande CLI permettant de choisir un autre dossier de destination.

ça permettrait à un utilisateur d'utiliser le script au travers d'un alias depuis n'importe quel répertoire, et de télécharger dans un autre, donné en paramètre, ou par défaut dans le répertoire de travail courant.

en: for instance, the content is downloaded in the project directory by default. my suggestion is to allow user to provide a destination directory in the CLI command. this would make a user able to use a command alias from any directory and downloading the data to a parametered directory, or by default in the current working directory. ----- fr: pour l'instant, le contenu est téléchargé par défaut dans le répertoire du projet. ma suggestion serait de rajouter un paramètre dans la commande CLI permettant de choisir un autre dossier de destination. ça permettrait à un utilisateur d'utiliser le script au travers d'un alias depuis n'importe quel répertoire, et de télécharger dans un autre, donné en paramètre, ou par défaut dans le répertoire de travail courant.
freezed commented 2022-12-08 17:39:07 +01:00
Owner
Copy link

Bien vu, ça se fera bien aec l'ajout d'argparse mentionné dans fcode/delarte#1

Bien vu, ça se fera bien aec l'ajout d'[`argparse`](https://docs.python.org/3/library/argparse.html) mentionné dans fcode/delarte#1
freezed changed title from [suggestion] download directory to Choix du répertoire de téléchargement temporaire 2022-12-08 17:42:45 +01:00
freezed added this to the devel project 2022-12-08 17:44:42 +01:00
Barbagus commented 2022-12-10 09:22:38 +01:00
Collaborator
Copy link

This as been partially addressed in the packaged version of the script. Once the package is pip-installed on your system, you might call the script from any location using

$ python -m delarte ....

or directly

$ delarte ....

The output file will be placed in the current directory.

This as been partially addressed in the packaged version of the script. Once the package is pip-installed on your system, you might call the script from any location using `$ python -m delarte ....` or directly `$ delarte ....` The output file will be placed in the current directory.
👍 1
freezed commented 2022-12-10 13:06:00 +01:00
Owner
Copy link

Please mention the last branch, merge request or commit with the implementation related to this isse and close this issue if necessary

A good practice is to mention this issue in the commit message to ease following-up

Please mention the last branch, merge request or commit with the implementation related to this isse and close this issue if necessary A good practice is to mention this issue in the commit message to ease following-up
Barbagus commented 2022-12-10 13:54:20 +01:00
Collaborator
Copy link

Commit: 9593619c68

"A good practice is to mention this issue in the commit message to ease following-up" => wilco.

Commit: 9593619c68 "A good practice is to mention this issue in the commit message to ease following-up" => wilco.
freezed commented 2022-12-11 23:01:02 +01:00
Owner
Copy link

Hi @remace07 , like on #1 it looks good for me too, see at line 48

If we are missing something, feel free to re-open this issue or open a new one related with this one.

Hi @remace07 , like on #1 it looks good for me too, see [at line 48](https://git.afpy.org/fcode/delarte/src/commit/9593619c68f31956eb9c8ea573fb53df9290fb16/README.md?display=source#L48) If we are missing something, feel free to re-open this issue or open a new one related with this one.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
stable
model
devel
draft
No results found.
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
devel
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#1 CLI argument/options and default behaviours
fcode/delarte
Reference
fcode/delarte#2
No description provided.