WIP: packaging and usage message #4

Barbagus · 2022-12-08T23:55:50Z

Barbagus commented

2022-12-08 23:55:50 +00:00

The program is now packaged and should be "pip installed" (see README) to run.

Issue #1: there is now a usage message printed when called with -h, --help or no arguments.

Issue #2: as the script is now to be "pip installed", it can be called from anywhere and the download will be put where it is called from.

The program is now packaged and should be "pip installed" (see README) to run. Issue #1: there is now a usage message printed when called with -h, --help or no arguments. Issue #2: as the script is now to be "pip installed", it can be called from anywhere and the download will be put where it is called from.

Barbagus added 11 commits 2022-12-08 23:55:51 +00:00

- refactor API calls d908e4f15b

- define namedtuple for "config" API

convert variable in main() to lowercase 6401c25205

factor out the actual stream download 2b9d8773bd

1) Parse and locally temp/rewrite the main m3u8 file to enable future selection af465ad79e

of resultion. Picks the bigger one for now.
2) Revrite subtitles selection to limit to selected resolution.

* refactoring using classmethods c0feaa820a

* video resolution selection
* use video/audio URLs directly in FFMPEG command
  (no temporary m3u8 file anymore)
* embed subtitle in final video file
* moved to MKV container to enable auto-on subtitle

Update readme and doc. 6057014598

Readme corrections fa2e57b121

Added .vscode to gitignore 7dba75faf3

reflect readme terminology in code 5125f1d6ba

Packaging with flit f22fe297c5

Setup the execution arch 9593619c68

freezed requested review from freezed 2022-12-09 09:49:05 +00:00

freezed added the

enhancement

label 2022-12-09 09:49:12 +00:00

freezed commented

2022-12-09 10:04:58 +00:00

Nice I'll take a look later 👍

About the process, try to use a branch. This could help to avoid mixing context in commit history:

factor out the actual stream download
Packaging with flit
Readme edition
…

Take a look to

git rebase, rewriting history could ease code review: README, .gitignore, packaging, etc.
Good commit message conventions

Nice I'll take a look later 👍 About the process, try to use a branch. This could help to avoid mixing context in commit history: * factor out the actual stream download * Packaging with flit * Readme edition * … Take a look to - [`git rebase`](https://git-scm.com/book/en/v2/Git-Branching-Rebasing), rewriting history could ease code review: README, .gitignore, packaging, etc. - [Good commit message conventions](https://cbea.ms/git-commit/)

Barbagus closed this pull request

2022-12-09 19:39:23 +00:00