move to `urllib3` instead of `requests` #29

Merged

Barbagus merged 2 commits from urllib3 into stable

2023-02-14 09:11:23 +01:00

Barbagus commented

2023-02-13 08:20:28 +01:00

Collaborator

HTTP features used by the program today are the one provided by requests underlying urllib3 library, namely:

connection pooling
content decoding

We do not use, and most probably will not use other features. Plus, the whole timeout argument propagation "thing" about requests is annoying to me.

HTTP features used by the program today are the one provided by `requests` underlying `urllib3` library, namely: - connection pooling - content decoding We do not use, and most probably will not use other features. Plus, the whole `timeout` argument propagation "thing" about `requests` is annoying to me.

Barbagus added 1 commit

2023-02-13 09:40:23 +01:00

Use urllib3 instead of requests a108135141

We were not (and probably wont be ) using any worthwhile `requests`
features (beside `raise_for_status()`) and the `timeout` session
parameter propagation vs adapter plugging "thing" in requests just
annoys me deeply (not that kind of "... Human (TM)")

Barbagus added 1 commit

2023-02-13 18:45:11 +01:00

Implement a raise_for_status() on HTTPError 477edc4910