move to urllib3 instead of requests #29

Barbagus · 2023-02-13T07:20:28Z

Barbagus commented

2023-02-13 07:20:28 +00:00

HTTP features used by the program today are the one provided by requests underlying urllib3 library, namely:

connection pooling
content decoding

We do not use, and most probably will not use other features. Plus, the whole timeout argument propagation "thing" about requests is annoying to me.

HTTP features used by the program today are the one provided by `requests` underlying `urllib3` library, namely: - connection pooling - content decoding We do not use, and most probably will not use other features. Plus, the whole `timeout` argument propagation "thing" about `requests` is annoying to me.

Barbagus added 1 commit 2023-02-13 08:40:23 +00:00

a108135141 Use `urllib3` instead of `requests`

We were not (and probably wont be ) using any worthwhile `requests`
features (beside `raise_for_status()`) and the `timeout` session
parameter propagation vs adapter plugging "thing" in requests just
annoys me deeply (not that kind of "... Human (TM)")

Barbagus added 1 commit 2023-02-13 17:45:11 +00:00

477edc4910 Implement a `raise_for_status()` on `HTTPError`

Barbagus changed title from ~~WIP: move to `urllib3` instead of `requests`~~ to move to `urllib3` instead of `requests`

2023-02-14 08:11:10 +00:00

Barbagus merged commit 23e2183c93 into stable

2023-02-14 08:11:23 +00:00

Barbagus deleted branch urllib3

2023-02-14 08:11:23 +00:00

Barbagus referenced this issue from a commit

2023-02-14 08:11:23 +00:00

Merge pull request 'move to `urllib3` instead of `requests`' (#29) from urllib3 into stable

Sign in to join this conversation.