refactoring #19

Closed

Barbagus wants to merge 4 commits from barbadev into stable

Barbagus commented

2022-12-20 10:16:20 +01:00

Collaborator

Getting lost trying to implement #11, I did do some helpfull (although, quasi-total) refactoring. I will push (probably not beofre Xmass) some of them over here for your consideration.

Barbagus added 1 commit

2022-12-20 23:49:16 +01:00

Use requests library instead of urllib 88ffe31a94

Enables by default:
- gzip compression
- request pooling

Barbagus force-pushed barbadev from d755bca5eb to 4c518993ef

2022-12-22 17:44:25 +01:00

Compare

Barbagus added 5 commits

2022-12-27 08:56:25 +01:00

Refactor website URL parsing 305d8ab679

Lighter implementation and using `target_id` instead of `program_id`,
preparing for #7

Create the data model types 4fa5e1953e

A bunch of data structures to be used instead of the types used by the
infrastructures, i.e. JSON for API and M3U8 for the HLS.

It should provide a stronger decoupling of the modules and pave the way
for #7 and #8.

Implementation uses `namedtuple`s as they are transparent to test for
equality and are natively hashable (can be used in `set`s or as keys to
`dict`s) which is useful for deduping for instance.

Refactor code to use the model types ca0a792617

- Rename variables and function to reflect model names.
- Convert infrastructure data (JSON, M3U8) to model types.
- Change algorithms to produce/consume `Source` model, in particular
  using generator functions to build a list of `Source`s rather than the
  opaque `rendition => variant => urls` mapping (this will make #7 very
  straight forward).

This was an extensive rewrite of the code base.

Rename error handling 7c4eac8e26

- move errors in a `error` module
- rename the module base error from `Error` to `ModuleError`
- fix some error handling in `__main__`

Provide programmatic access #20 fad48ff661

Barbagus commented

2022-12-27 09:21:07 +01:00

Author

Collaborator

Something important I failed to mention was done in ca0a792617 :

We use to offer rendition choosing right after the api call, before we download the appropriate master playlist to figure out the available variants.

The problem with that is that ArteTV's codes for the renditions (given by the api) do not necessarly include complete languages information (if it is not French or German), for instance a original audio track in portugese would show as VOEU- (as in "EUropean"). The actuall mention of the Portugese would only show up in the master playlist.

So, the new implementation actually downloads all master playlists straight after the api call. This is a bit wastefull, but I figured it was necessary to provide quality interaction with the user.

Bonus? Now when we first prompt the user for rendition choice, we actually already know the available variants available, maybe we make use of that fact in the future...

Something important I failed to mention was done in ca0a792617 : We use to offer _rendition_ choosing right after the `api` call, before we download the appropriate _master playlist_ to figure out the available _variants_. The problem with that is that ArteTV's _codes_ for the _renditions_ (given by the `api`) do not necessarly include complete languages information (if it is not French or German), for instance a original audio track in portugese would show as `VOEU-` (as in "EUropean"). The actuall mention of the Portugese would only show up in the _master playlist_. So, the new implementation actually downloads all _master playlists_ straight after the `api` call. This is a bit wastefull, but I figured it was necessary to provide quality interaction with the user. Bonus? Now when we first prompt the user for _rendition_ choice, we actually already know the available _variants_ available, maybe we make use of that fact in the future...

Barbagus commented

2022-12-27 09:22:53 +01:00

Author

Collaborator

Next step is to update/rewrite the README to reflect the changes... then I'll take the WIP off.

Next step is to update/rewrite the `README` to reflect the changes... then I'll take the `WIP` off.

Barbagus added 1 commit

2022-12-28 09:59:31 +01:00

Update README to reflect changes b90328e369

Barbagus changed title from ~~WIP: refactoring~~ to refactoring

2022-12-28 10:00:02 +01:00

Barbagus referenced this pull request