fix: consider finished files and hide them from output by default

Not sure if there's an elegant way to do it, but I would prefer the overall percentage to always take completed files into consideration in completion calculations, independently from showing the completed files in detailed output or not. I think it's more natural that way.

mattwang44 commented

2024-11-19 17:09:59 +01:00

Author

Contributor

Not sure if there's an elegant way to do it, but I would prefer the overall percentage to always take completed files into consideration in completion calculations, independently from showing the completed files in detailed output or not. I think it's more natural that way.

@maciek Not sure if I understand you correctly, but I believe this change below in select() would have the calculation considered for those finished files. The rest changes are to hide them from output by default and show them if --show-finished is given.

	    if (
-            po_file.percent_translated == 100
-            or po_file.percent_translated < args.above
+            po_file.percent_translated < args.above
            or po_file.percent_translated > args.below
        ):
            return False

> Not sure if there's an elegant way to do it, but I would prefer the overall percentage to always take completed files into consideration in completion calculations, independently from showing the completed files in detailed output or not. I think it's more natural that way. @maciek Not sure if I understand you correctly, but I believe this change below in `select()` would have the calculation considered for those finished files. The rest changes are to hide them from output by default and show them if `--show-finished` is given. ```diff if ( - po_file.percent_translated == 100 - or po_file.percent_translated < args.above + po_file.percent_translated < args.above or po_file.percent_translated > args.below ): return False ```

maciek commented

2024-11-19 23:55:31 +01:00

Contributor

Ah, ok, thanks for explaining. Sorry for confusion! I wasn't careful enough reading through changes. I like the proposed behaviour! 👍

👍 1 ❤️ 1