AFPy/potodo
AFPy/potodo
11
3
Fork 7
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity

Base completion on number of words in msgids #20

Merged
mdk merged 11 commits from maciek/potodo:word-counts into main 2025-10-16 16:06:25 +02:00
Conversation 4 Commits 11 Files changed 6 +52 -60
maciek commented 2025-07-15 23:40:59 +02:00
Contributor
Copy link

Closes #13.

Closes #13.
mattwang44 reviewed 2025-07-16 12:23:09 +02:00
potodo/po_file.py Outdated
@ -72,8 +82,12 @@ class PoFileStats:
),
"percent_translated": pofile.percent_translated(),
"entries": len([e for e in pofile if not e.obsolete]),
"words": sum([len(e.msgid.split()) for e in pofile if not e.obsolete]),
mattwang44 commented 2025-07-16 12:22:18 +02:00
Contributor
Copy link

nit: consider leaving a TODO comment mentioning that it can later be modified as e.total_words() and e.translated_words() after polib supports these methods.

nit: consider leaving a TODO comment mentioning that it can later be modified as e.total_words() and e.translated_words() after polib supports these methods.
👍 1
maciek marked this conversation as resolved
potodo/po_file.py Outdated
@ -75,2 +86,4 @@
"untranslated": len(pofile.untranslated_entries()),
"translated": len(pofile.translated_entries()),
"translated_words": sum(
[len(e.msgid.split()) for e in pofile.translated_entries()]
mattwang44 commented 2025-07-16 12:22:53 +02:00
Contributor
Copy link

related issue: https://github.com/izimobil/polib/pull/166#discussion_r2209880615

related issue: https://github.com/izimobil/polib/pull/166#discussion_r2209880615
mattwang44 commented 2025-07-16 14:48:30 +02:00
Contributor
Copy link

not an issue after clarification

not an issue after clarification
maciek marked this conversation as resolved
mattwang44 approved these changes 2025-07-16 14:49:03 +02:00
mattwang44 left a comment
Copy link

LGTM

LGTM
maciek commented 2025-08-16 02:24:07 +02:00
Author
Contributor
Copy link

I've added word completion to project class (missed earlier), and added a new test assert for TOTAL. Also added TODOs according to the comment.

I've added word completion to project class (missed earlier), and added a new test assert for `TOTAL`. Also added TODOs according to the comment.
👍 1
StanFromIreland approved these changes 2025-09-11 16:45:22 +02:00
potodo/po_file.py
@ -133,2 +157,4 @@
return sum(po_file.words for po_file in self.files_stats)
@property
def completion(self) -> float:
StanFromIreland commented 2025-09-11 16:42:26 +02:00
First-time contributor
Copy link

Changing this will may cause large changes in the returned result, I think this should be an option as so to not surprise people.

Changing this will may cause large changes in the returned result, I think this should be an option as so to not surprise people.
maciek commented 2025-09-11 23:26:03 +02:00
Author
Contributor
Copy link

I think those are good defaults, I'd be for including this change in a changelog and maybe bumping library version to 1.0.0? @seluj78 @mdk what do you think?

I think those are good defaults, I'd be for including this change in a changelog and maybe bumping library version to 1.0.0? @seluj78 @mdk what do you think?
potodo/po_file.py
@ -201,2 +240,4 @@
)
@property
def completion(self) -> float:
StanFromIreland commented 2025-09-11 16:43:28 +02:00
First-time contributor
Copy link

Ditto.

Ditto.
mdk merged commit b4f5a2978e into main 2025-10-10 14:37:29 +02:00
mdk deleted branch word-counts 2025-10-10 14:37:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mattwang44
StanFromIreland
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AFPy/potodo!20
No description provided.