[JacoPad] Arduino #46

Adrien · 2024-04-23T17:26:23Z

Adrien commented

2024-04-23 17:26:23 +00:00

[JacoPad] Arduino

# [JacoPad] Arduino

Adrien added 11 commits 2024-04-23 17:26:24 +00:00

[JacoBot] Motor encoder basic Arduino implementation with PID 97f126835c

Add arduino bumper model c2213b3991

Start integrate NRF24 module 0fdb58b6cc

Author:    Linux_Hat <adrien@d4x.fr>

I commit the wrong stl, i am stupid 1b886bab7d

[NOT WORKING] I try things but it doesn't work :( 8294b9c0d1

[NOT WORKING] I think I found thomething... ea3a44c024

Token detection 97dd28a88a

Revert "Token detection" 2445f801e7

This reverts commit 97dd28a88a.

	deleted:    jacopad/arduino/README.md
	deleted:    jacopad/arduino/main.cpp
	deleted:    jacopad/arduino/token.cpp
	deleted:    jacopad/arduino/token.h

Revert "[NOT WORKING] I think I found thomething..." e8eb8f34a3

This reverts commit ea3a44c024.

	modified:   jacobot/arduino/Car.cpp
	modified:   jacobot/arduino/MotorEncoder.cpp
	modified:   jacobot/arduino/main.cpp
	deleted:    jacopad/arduino/.gitkeep

Merge branch 'main' of git.afpy.org:Adrien/JacoBot into experimental 2020fed424

Detection of the token 51545da322

Adrien added the

JacoPad

Hardware

labels 2024-04-23 17:27:39 +00:00

Adrien added 1 commit 2024-04-23 17:36:22 +00:00

fix git edbb697b29

Adrien added 1 commit 2024-04-23 17:38:27 +00:00

git fix 2 git add * 424a8cc7d4

Adrien added 1 commit 2024-04-23 17:42:05 +00:00

GIT FIX FINAL git add jacopad/ aa39e44c81

Adrien added 1 commit 2024-04-23 17:48:56 +00:00

GIT FIX FINAL 2 git push origin jacopad git push origin jacopad git push origin jacopad git push origin jacopad e8f2ed633a

Adrien added 1 commit 2024-04-23 17:52:29 +00:00

GIT FIX FINAL FINAL ddcfe68896

benvii requested changes 2024-04-24 09:42:59 +00:00

benvii left a comment

Good job but need to add an enum to represent each token type and return the enum value.

jacopad/arduino/token.h Outdated

						
				@ -0,0 +3,4 @@

				// Token class declaration

				class Token {

				private:

				    int m_pin;            // Pin number connected to the sensor

benvii commented

2024-04-24 09:17:10 +00:00

Add that this pin will measure the resistance.

Adrien marked this conversation as resolved

jacopad/arduino/token.h Outdated

						
				@ -0,0 +11,4 @@

				public:

				    // Constructor declaration

				    Token(int pin, float base, float limits[3], float min, float max);

benvii commented

2024-04-24 09:35:45 +00:00

Add doxygen doc and explain the format of limits array, like this :

 * @param limits array meaning, for those values : {1000.0, 4000.0, 7500.0}
                     < 1000 Ω                 <  4000 Ω                     <  7500 Ω
      Token 1                   Token 2                  Token 3             Token 4

You will need to add a table with the list of instruction named associated to each type of token or make a enum then return the number of the enum.
Document base, indicate that this this the constant resistance value use in the tension divider (outside of the token)

- [ ] Add doxygen doc and explain the format of limits array, like this : ``` * @param limits array meaning, for those values : {1000.0, 4000.0, 7500.0} < 1000 Ω < 4000 Ω < 7500 Ω Token 1 Token 2 Token 3 Token 4 ``` - [ ] You will need to add a table with the list of instruction named associated to each type of token or make a enum then return the number of the enum. - [ ] Document base, indicate that this this the constant resistance value use in the tension divider (outside of the token)

Adrien marked this conversation as resolved

jacopad/arduino/token.h

						
				@ -0,0 +17,4 @@

				    float read();

				    // Method to determine and return the type of token based on the sensor value

				    int type();